Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments from Deb and Russ #20

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Address comments from Deb and Russ #20

merged 1 commit into from
Nov 15, 2024

Conversation

danvangeest
Copy link
Collaborator

@danvangeest danvangeest commented Nov 14, 2024 •
edited
Loading

BashiriK
BashiriK approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@BashiriK BashiriK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, I did not understand how you resolved Russ' comment at lines 338 and 369. But it's definitely me, not you :-)

@danvangeest danvangeest merged commit db8d400 into main Nov 15, 2024
2 checks passed
@danvangeest danvangeest deleted the dvg/Deb_and_Russ_comments branch November 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BashiriK BashiriK BashiriK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danvangeest @BashiriK